assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
23 stars 6 forks source link

use ISO-8601 date format for direct yaml parsing #319

Closed maurerle closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.45%. Comparing base (27a8ebf) to head (bc1edb5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #319 +/- ## ======================================= Coverage 77.45% 77.45% ======================================= Files 43 43 Lines 5016 5016 ======================================= Hits 3885 3885 Misses 1131 1131 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/319/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/319/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.45% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nick-harder commented 6 months ago

@maurerle depending on users not to forget T and followi this exact format is somehow not very intuitive. Is there some specific reason for this?

maurerle commented 6 months ago

Mostly just me wondering, why the yaml does not read this into datetime directly ^^ So we can keep the current behavior in favor of usability.