assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

Fixed complex clearing when using pyomo>=6.7 #333

Closed nick-harder closed 4 months ago

nick-harder commented 4 months ago

-create dual suffix only when needed and available -fix notebook 6 -fix nodal test

closes #326

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.34%. Comparing base (40d7692) to head (7fafa43).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #333 +/- ## ======================================= Coverage 77.33% 77.34% ======================================= Files 43 43 Lines 5013 5015 +2 ======================================= + Hits 3877 3879 +2 Misses 1136 1136 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.34% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maurerle commented 4 months ago

I think you can still remove the pip install restriction in the notebook? or did you?

The one Johanna introduced in #325