assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

correctly calculate offset of current timezone #336

Closed maurerle closed 2 months ago

maurerle commented 3 months ago

We should calculate the offset of our current timezone at unix_epoch=0 to have the correct offset

We calculated the offset of our current time, which might change throughout the year, due to summer time. By taking the offset in January 1970, this matches the date we were comparing

This test did not fail in CI, as the CI always runs in UTC and therefore has an offset of 0

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.36%. Comparing base (6ef25e0) to head (0d285c8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ======================================= Coverage 77.36% 77.36% ======================================= Files 43 43 Lines 5018 5018 ======================================= Hits 3882 3882 Misses 1136 1136 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/336/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.