assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

Fix handling of rejected bids #338

Closed nick-harder closed 2 months ago

nick-harder commented 2 months ago
  1. fix accepted_volume and accepted price being removed if already defined by the market
  2. remove logging noise from pypsa scripts
  3. remove unrequired clean up of all_orders from newer market clearing algorithms
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.40%. Comparing base (93f7bd6) to head (939e8b9).

Files Patch % Lines
assume/markets/base_market.py 66.66% 2 Missing :warning:
assume/markets/clearing_algorithms/redispatch.py 0.00% 2 Missing :warning:
...ssume/markets/clearing_algorithms/nodal_pricing.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #338 +/- ## ========================================== + Coverage 77.37% 77.40% +0.03% ========================================== Files 43 43 Lines 5020 5018 -2 ========================================== Hits 3884 3884 + Misses 1136 1134 -2 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/338/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.40% <44.44%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.