assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

Restructure setting obs and act observations and return unique observations #351

Closed nick-harder closed 1 month ago

nick-harder commented 1 month ago

-set obs_dim and act_dim as properties of bidding startegies -remove these values from configs -set them as fixed values in startegies -learning role checks if all strategies have the same dimensions -raise an error if not the same dimensions -include unique observations in the critic

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 77.97%. Comparing base (b9b177a) to head (0d7f435).

Files Patch % Lines
assume/reinforcement_learning/learning_utils.py 57.89% 8 Missing :warning:
assume/reinforcement_learning/algorithms/matd3.py 86.95% 3 Missing :warning:
assume/world.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 78.07% 77.97% -0.11% ========================================== Files 43 43 Lines 5090 5116 +26 ========================================== + Hits 3974 3989 +15 - Misses 1116 1127 +11 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.97% <76.47%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.