codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 77.94%. Comparing base (
d95f181) to head (330b2c3).:exclamation: Current head 330b2c3 differs from pull request most recent head 5f521b7. Consider uploading reports for the commit 5f521b7 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| assume/scenario/loader_csv.py | 95.91% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #353 +/- ## ========================================== - Coverage 77.97% 77.94% -0.03% ========================================== Files 43 43 Lines 5116 5128 +12 ========================================== + Hits 3989 3997 +8 - Misses 1127 1131 +4 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.94% <95.91%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
kim-mskw
This PR splits the scenario loader into two parts, keeping the files and other things in memory to avoid loading everyhting multiple times when in training