search

assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

update architecture.svg #360

Closed maurerle closed 1 day ago

maurerle commented 3 weeks ago

I updated the architecture.svg to match recent developments. Though I am open for more input on this change

maurerle commented 2 weeks ago

Side by side: On the left, the new layout better reflects the actual usage of markets in the architecture.

image

Pipeline is failing due to #367

nick-harder commented 2 weeks ago

I believe, the positioning should be kept as before since it allowed to see two sides easily. Also, I believe the network and the clearing is better represented as plun&play parts for easier demonstration and explanation. tbh I don't completely understand what changed compared to the current version of the architecture?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.77%. Comparing base (bf809da) to head (80f2b52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #360 +/- ## ========================================== - Coverage 78.20% 77.77% -0.43% ========================================== Files 44 44 Lines 5179 5179 ========================================== - Hits 4050 4028 -22 - Misses 1129 1151 +22 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/360/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.77% <ø> (-0.43%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maurerle commented 1 week ago

New images:

image.svg

and I created another one without minimized configs: noconfig.svg

I would just add the architecture.svg

I also updated the actor and critic usage according to the usage in the source code, and updated the LearningRole :)

kim-mskw commented 1 week ago

That looks good. Thank you :)

With regard to the learning, I would suggest, that the actor is still connected as before to the learning role because the learning role has an algorithm that has the actors. Though we do not depict the algorithm here. To keep it simple I would not do so, but add it below the buffer and then draw the line from learning role to actor again. I can also do that if you provide me with the file.

maurerle commented 5 days ago

Hi Kim, actually the LearningRole has a list of learning_strategies and can access the actos through these, as correctly shown in the image ;) Though I am open for suggestions and improvements.

You can edit the file by just opening the svg with draw.io/diagrams.net Just do as you like :)

kim-mskw commented 1 day ago

Hi Kim, actually the LearningRole has a list of learning_strategies and can access the actos through these, as correctly shown in the image ;) Though I am open for suggestions and improvements.

You can edit the file by just opening the svg with draw.io/diagrams.net Just do as you like :)

you are of course right, because we changed that