assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
23 stars 6 forks source link

Fix missing market dispatch values when running day-ahead markets #380

Closed nick-harder closed 3 months ago

nick-harder commented 3 months ago

The +1 in the function collecting the market dispatch for the units was causing that the first order was never collcted, leading to gaps in the outputs image

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.92%. Comparing base (8973314) to head (d7d92e0).

:exclamation: Current head d7d92e0 differs from pull request most recent head e44c158

Please upload reports for the commit e44c158 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #380 +/- ## ========================================== - Coverage 77.88% 74.92% -2.97% ========================================== Files 43 43 Lines 5132 5120 -12 ========================================== - Hits 3997 3836 -161 - Misses 1135 1284 +149 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `74.92% <ø> (-2.97%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.