assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
22 stars 5 forks source link

do not sort twice #389

Closed maurerle closed 1 month ago

maurerle commented 1 month ago

Pull Request

Related Issue

Closes #[issue number] (if applicable)

Description

Do not sort orderbooks twice

Fixup for #388

Checklist

Please check all applicable items:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b6b956a). Learn more about missing BASE report.

Files Patch % Lines
assume/markets/clearing_algorithms/contracts.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #389 +/- ## ======================================= Coverage ? 78.20% ======================================= Files ? 44 Lines ? 5181 Branches ? 0 ======================================= Hits ? 4052 Misses ? 1129 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/389/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `78.20% <50.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.