search

ast-grep / ast-grep-vscode

ast-grep VSCode is a structural search and replace extension for many languages.
https://marketplace.visualstudio.com/items?itemName=ast-grep.ast-grep-vscode
MIT License
156 stars 11 forks source link

extension is unreadable on most dark themes #134

Closed bradzacher closed 8 months ago

bradzacher commented 8 months ago

I'm using the "Dark+" colour theme and the search results renders poorly:

image

I tried a few different built-in dark themes and they all have the same problem of using black for the text: Abyss, "Dark (Visual Studio)", "Dark High Contrast", "Kimbie Dark", Monokai, "Monokai Dimmed", Red, "Solarized Dark", "Tomorrow Night Blue".

The only one that I could get to work was "Dark Modern" and OFC the light themes.

Particularly bad was the "Dark High Contrast" theme because it uses black as the background - so you have black text on a black background and the highlight is hidden: image

HerringtonDarkholme commented 8 months ago

Thanks for the report!

SoonIter commented 8 months ago

related to #131, interesting about why different themes have different behaviors