astahlman / ob-async

Asynchronous src_block execution for org-babel
348 stars 32 forks source link

RESULTS replaced before the confirmation #23

Closed avkoval closed 6 years ago

avkoval commented 6 years ago

Checklist

Expected Behavior

Consider following simple template:

#+BEGIN_SRC sh :dir ~ :results output replace :async 
echo Hello, World!
#+END_SRC

When I press C-c I get:

Evaluate this sh code block on your system? (y or n) y and the RESULTS block is changed to:

#+RESULTS:
: 6fc00bde7e0c6b7623f6e3e05c16fbba

after I confirm the execution

Actual Behavior

When I press C-c I get RESULTS block changed immediately, the answer y/n does not matter

#+RESULTS:
: 6fc00bde7e0c6b7623f6e3e05c16fbba
astahlman commented 6 years ago

Care to review? https://github.com/astahlman/ob-async/pull/24/files?w=1

avkoval commented 6 years ago

Absolutely amazing reaction to my issue, I was hoping but did not expected you to fix it so fast. Thank you, it worked well against my use-cases.

astahlman commented 6 years ago

Glad to hear it!