search

astahlman / ob-async

Asynchronous src_block execution for org-babel
343 stars 32 forks source link

Typo in ob-async-org-babel-execute-src-block: Symbol’s function definition is void: -if-let #25

Closed bgoodr closed 6 years ago

bgoodr commented 6 years ago

Checklist

Expected Behavior

Should just work without a error about void function.

Actual Behavior

Got: error in process sentinel: Symbol’s function definition is void: -if-let

Steps to Reproduce

See the troubleshooting.org file linked below in a gist for my analysis. See the very end of it.

Side note: the troubleshooting.org file references the need to manually update a hook function, but the code indicates that is not needed. installing the package from Melpa did not automatically update a hook function and I conclude the troubleshooting.org file is out of date with what is actually required.

Troubleshooting Artifacts

Here is the link to my copy of the troubleshooting.org file: https://gist.github.com/bgoodr/ae0e048bb5fe6e660bfff3ac96744cf8

astahlman commented 6 years ago

Thanks for reporting @bgoodr, this was definitely a bug - the -if-let macro cromes from the dash package, which ob-async depends on but didn't explicitly declare. I've just merged https://github.com/astahlman/ob-async/pull/26 which makes the dependency explicit.

Side note: I considered just using if-let, but it looks like that wasn't built in to Emacs before Emacs 25. If and when we drop support for Emacs 24, we could eliminate the dependency on dash by changing -if-let to if-let

bgoodr commented 6 years ago

Thank you!

On Mon, Apr 23, 2018 at 8:47 AM, Andrew Stahlman notifications@github.com wrote:

Closed #25 https://github.com/astahlman/ob-async/issues/25.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/astahlman/ob-async/issues/25#event-1589504734, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIoB6aASvyERjvhPo-Ev7PQrg9cFattks5trfevgaJpZM4TVkeu .