astahlman / ob-async

Asynchronous src_block execution for org-babel
348 stars 32 forks source link

ob-async seems ignored :dir header argument #44

Closed stardiviner closed 5 years ago

stardiviner commented 5 years ago

Checklist

Expected Behavior

The source block should take advantage of :dir header argument.

Actual Behavior

It seems missed it.

And it report error:

executing Sh code block...
Saving file /home/stardiviner/Org/Wiki/Computer Technology/Operating System/Linux/Command Line/Command Line.org...
Wrote /home/stardiviner/Org/Wiki/Computer Technology/Operating System/Linux/Command Line/Command Line.org
source-code block ‘12:16:53>’ not found in this buffer
error in process sentinel: save-current-buffer: Opening output file: No such file or directory, /home/stardiviner/Org/Wiki/Computer Technology/Operating System/Linux/Command Line/the-art-of-command-line/README.md
error in process sentinel: Opening output file: No such file or directory, /home/stardiviner/Org/Wiki/Computer Technology/Operating System/Linux/Command Line/the-art-of-command-line/README.md
Mark set

Steps to Reproduce

#+begin_src sh :mkdirp yes :results file link :dir "Data/Books" :file "the-art-of-command-line/README.md" :async
if [ -d the-art-of-command-line ]; then
  cd the-art-of-command-line ; git pull
else
  git clone --recursive https://github.com/jlevy/the-art-of-command-line.git the-art-of-command-line
fi
#+end_src

Without the ~:async~, it works fine.

Troubleshooting Artifacts

https://gist.github.com/stardiviner/28d9dd594a4de2fa726277c279760387

astahlman commented 5 years ago

Thanks for reporting - I've just opened https://github.com/astahlman/ob-async/pull/45 with a fix. Can you review and confirm that the fix works?

stardiviner commented 5 years ago

I review the code, and test on the branch. It works fine. Thanks for quick patch. You're awesome.