astahlman / ob-async

Asynchronous src_block execution for org-babel
343 stars 32 forks source link

ob-async does not respect Org 9.2 new :results file link #51

Closed stardiviner closed 5 years ago

stardiviner commented 5 years ago

Checklist

Expected Behavior

The result link of file should not be overriden by process output. It's just a link to file.

#+begin_src sh :mkdirp yes :results file link :dir "data/code" :file "clj-new/README.md" :async
if [ -d clj-new ]; then
  cd clj-new ; git pull
else
  git clone --recursive https://github.com/seancorfield/clj-new.git clj-new
fi
#+end_src

#+RESULTS[<2019-01-30 17:45:40> 7e8b186da3d33354172f44ce8cc54416b3fe0405]:
[[file:data/code/clj-new/README.md]]

Actual Behavior

The result link of file is overriden by process output.

#+begin_src sh :mkdirp yes :results file link :dir "data/code" :file "clj-new/README.md" :async
if [ -d clj-new ]; then
  cd clj-new ; git pull
else
  git clone --recursive https://github.com/seancorfield/clj-new.git clj-new
fi
#+end_src

#+RESULTS[<2019-01-30 17:45:40> 7e8b186da3d33354172f44ce8cc54416b3fe0405]:
[[file:data/code/clj-new/README.md]]

I tested without :async. It works fine. Once I added :async, it works wrong.

Steps to Reproduce

Troubleshooting Artifacts

stardiviner commented 5 years ago

I added a patch to simply fix this.

https://github.com/astahlman/ob-async/pull/52

astahlman commented 5 years ago

Merged, thanks for the PR!

stardiviner commented 5 years ago

thanks