astahlman / ob-async

Asynchronous src_block execution for org-babel
343 stars 32 forks source link

Make async-inject variables customizable #72

Closed dakra closed 3 years ago

dakra commented 3 years ago

This gives users the option to inject different variables that the need for execution of the source blocks. E.g. to evaluate SQL SRC blocks with the :dbconnection attribute you need to have sql-connection-alist set.

astahlman commented 3 years ago

@dakra thanks for the PR, and sorry for the slow response. Mind adding a unit test that verifies the behavior?

dakra commented 3 years ago

No problem.

I just pushed a test as well.

My use-case is that if you use sql source block with :dbconnection parameter, org looks that parameter up in sql-connection-alist. Maybe it even makes sense to inject that by default plus all org-babel-* variables? (But not necessary, setting it in my own config is also good)

astahlman commented 3 years ago

@dakra tests look great, thanks for your contribution!