astahmer / openapi-zod-client

Generate a zodios (typescript http client with zod validation) from an OpenAPI spec (json/yaml)
openapi-zod-client.vercel.app
734 stars 82 forks source link

additionalPropertiesDefaultValue implementation bug #244

Open amvFrontendMonkey opened 10 months ago

amvFrontendMonkey commented 10 months ago

In the PR - https://github.com/astahmer/openapi-zod-client/pull/230/files - the cli switch --additional-props-default-value false is not coerced into a boolean before the check within openApiToZod.ts (const additionalPropsSchema = additionalProps === false ? "" : ".passthrough()";)

astahmer commented 10 months ago

would you like to send a PR ?

amvFrontendMonkey commented 10 months ago

ah, this is a work account and i'm not on the project anymore.

Sorry to say then, I won't

amvFrontendMonkey commented 4 months ago

@astahmer I'd be willing to provide a PR for this

Is this something you'd accept?