search

astamm / nloptr

nloptr provides an R interface to NLopt, a free/open-source library for nonlinear optimization providing a common interface to a number of different optimization routines which can handle nonlinear constraints and lower and upper bounds for the controls.
https://astamm.github.io/nloptr/
Other
105 stars 35 forks source link

Fix for R before 4 #106

Closed tuxmaster5000 closed 2 years ago

tuxmaster5000 commented 2 years ago

Fir for https://github.com/astamm/nloptr/issues/105

tuxmaster5000 commented 2 years ago

Now the test for version 4.0.0 is used.

tuxmaster5000 commented 2 years ago

What do mean? The code do it's job without open any security holes.

eddelbuettel commented 2 years ago

Our repo, our code requirements. Please consider making the requested changes to get your PR merged.

astamm commented 2 years ago

What Dirk tries to convey here is that the owners of any code most of the time follow conventions when writing their code and it is good practice to follow the same rules when contributing to this code. Some go even so far as to write a code of conduct that any contributor should follow in order to contribute. We would be very grateful if you could implement Dirk's suggestions so that we can merge your PR.

astamm commented 2 years ago

We thank you very much for your contribution @tuxmaster5000. Can you please make the final modifications so that I can merge your PR?

astamm commented 2 years ago

@tuxmaster5000 can you please modify your code as per @eddelbuettel requests please ? It's been a while now. I will close this PR tomorrow in alternative and implement a fix myself. But that would be very time inefficient for everybody. Thanks.