search

astamm / nloptr

nloptr provides an R interface to NLopt, a free/open-source library for nonlinear optimization providing a common interface to a number of different optimization routines which can handle nonlinear constraints and lower and upper bounds for the controls.
https://astamm.github.io/nloptr/
Other
103 stars 36 forks source link

Seeming bug in global.R #128

Closed aadler closed 1 year ago

aadler commented 1 year ago

Hi @astamm. This seems to be a clear mistake in that match.fun was meant. I'm in the process of building a relatively robust test suite prior to making any substantive changes to prevent issues similar to my prior pull request, but this seems like low-hanging fruit.

astamm commented 1 year ago

Hey @aadler. Thanks! Do you want me to merge that PR provided workflows pass or are you planning to add more commits to it?

aadler commented 1 year ago

If it passes, please merge it. I've merged it with my test-building branch. When that is done I'll send a PR and then start on tweaking—carefully!

astamm commented 1 year ago

Done. Thanks.