search

astanin / python-tabulate

Pretty-print tabular data in Python, a library and a command-line utility. Repository migrated from bitbucket.org/astanin/python-tabulate.
https://pypi.org/project/tabulate/
MIT License
2.1k stars 163 forks source link

Fix code quality errors #265

Open arpitjain099 opened 1 year ago

arpitjain099 commented 1 year ago

I ran CodeQL scanning on the project and found the following 10 alerts.

image

I fixed 4 alerts and made this PR. Please review

image
eliegoudout commented 1 year ago

Hello @arpitjain099, Sorry for asking you here, but do you have the rights to review / merge PRs? I think this repo is lacking activity recently and I would really like to have #221 merged for a project. It closes 11 issues as well as adding functionality.

Thank you in advance, and sorry for commenting somewhere unrelated.

All the best!

arpitjain099 commented 1 year ago

@eliegoudout no I do not. I didn't know this repo is not being actively managed anymore. This repo is being used by a lot of devs (more than 5M downloads from PyPI). Surprised it's not being managed anymore.

astanin commented 1 year ago

Hi @arpitjain099 @eliegoudout

I'm the project owner and maintainer. I do and intend to maintain this project going forward but it is a hobby project, and it takes a back seat after the day job, family, sport, and other hobbies. In practice, that means

0) I review and merge submissions approximately once or twice per year

1) Priority is on maintaining backwards compatibility and supporting new Python versions

2) Low priority stuff that might never be merged: code formatting, changing too many lines of code, new dependencies, introducing new workflows, integrating with yet another CI service.

3) New features: medium priority. I consider this project to be good enough as it is. It was certainly good for my needs. I try to avoid breaking old use cases.

4) Submitting pull requests is the best way to change/fix something in the project.

5) Small focused PRs are more likely to be merged. I might not have time to cherry-pick changes from a huge PR which may also conflict with something else.

6) Expect ~ 6 months lead time before it goes into a release.

@eliegoudout pull request #221 seems good, it doesn't break stuff as far as I can see. I'm not sure about printing warnings. I'd rather prefer it to do its best silently. There're some code formatting issues, but nothing that black cannot fix.

arpitjain099 commented 1 year ago

@astanin thank you for the reply. I see that there are some merge conflicts now - let me resolve them and send the PR back to you for review.