search

astanin / python-tabulate

Pretty-print tabular data in Python, a library and a command-line utility. Repository migrated from bitbucket.org/astanin/python-tabulate.
https://pypi.org/project/tabulate/
MIT License
2.16k stars 165 forks source link

Fix support for separating lines #279

Closed pjkundert closed 2 weeks ago

pjkundert commented 1 year ago

Resolves #246

davidlatte commented 11 months ago

It would be great to get this PR merged and released!

astanin commented 1 month ago

I tried merging this commit with master (see pr-279 branch), but the tests fail in test_simple_headerless_with_sep_line_with_linebetweenrows_in_tablefmt.

Expected output:

+------+----------+
| spam |  41.9999 |
+------+----------+
+------+----------+
| eggs | 451      |
+------+----------+

actual output:

+------+----------+
| spam |  41.9999 |
+------+----------+
||
+------+----------+
| eggs | 451      |
+------+----------+

Possible interaction with the changes introduced in pull request #331. Or I might have broken it during the merge.

pjkundert commented 2 weeks ago

A check for SEPARATING_LINE got skipped, @astatin; I added it back in. Passes tests now.

astanin commented 2 weeks ago

@pjkundert Thank you. I think this can be merged now.