astanin / python-tabulate

Pretty-print tabular data in Python, a library and a command-line utility. Repository migrated from bitbucket.org/astanin/python-tabulate.
https://pypi.org/project/tabulate/
MIT License
2.17k stars 164 forks source link

minor change to fix issue preventing passing in an interable for showindex #337

Open rebeccaherman1 opened 2 months ago

rebeccaherman1 commented 2 months ago

Added check that showindex_is_a_str before comparing showindex == "default", which causes an error when showindex is an iterable.

rebeccaherman1 commented 2 months ago

It would be nice if the vertical line separating the index from the table could have the same format as the horizontal line separating the headers from the table. Would someone be able to implement that?

rebeccaherman1 commented 2 months ago

I do not understand why there is a failing check -- I have barely changed anything. Assistance would be appreciated.

astanin commented 1 month ago

The failing test on Appveyor is not related to this PR.

Still before I can accept this PR I need unit tests (test/test_input.py, test/test_output.py) and a reference to an issue it tries to solve.