davidebriani
commented
1 year ago The PR has nice body of work, thanks for the sweat and tears put into it :) I'll leave some general guidelines we strive to follow during our workflow:
- A good practice would be to divide the body of work into multiple commits, each one dedicated to introducing a specific change. This practice allows others to review the changes more easiliy, improves clarity on the concepts for the introduced changes, and helps tracking down bugs to specific lines of code when issues arise (e.g. thanks to
git bisect). In essence:- Each commit should be as atomic and self-consistent as possible. The commit should have a title, which is a short summary of the change, and a detailed description possibly expressing the reasons of the change and the implications.
- For each commit, it should always be possible to build and use the project without issues
- GitHub has a nice functionality that helps code review and also helps presenting your work clearly to others: you can drag&drop a picture or a video onto the input box for the PR's description and GitHub will nicely render it so that others can see a visual recording of what your changes are about.
- When a commit closes an issue, you can include
Closes #<issue number>in the commit description too.
On Astarte Dashboard, added a new page for Trigger policies. On new trigger policies page added functionality for listing and adding new trigger policies. On new trigger policy editor user can enter name of the policy, can add multiple handlers, set retry times, maximum capacity and message lifetime.
Closes #367 Closes #368 Closes #370