search

astarte-platform / astarte-dashboard

Astarte dashboard
http://astarte-platform.org
Apache License 2.0
17 stars 16 forks source link

Improve history navigation after authentication #386

Closed Hibe7 closed 1 year ago

Hibe7 commented 1 year ago

Improve history navigation by replacing the browser's location

Closes #385

davidebriani commented 1 year ago

@Hibe7 the PR is good, but since it's a fix that is also suitable for the v1.1 releases, it would be great to merge the PR in the release-1.1 branch.

There are a few changes you would have to do:

  1. Rebase the PR onto the release-1.1 branch, instead of master. Also update the target branch of the PR to release-1.1.
  2. Since the last commit of that branch was used to tag the 1.1.0 release, your PR will need to have an initial commit to prepare the next development cycle: we need to change the versions in the package.json and package-lock.json to v1.1.1-dev, and a line ## [Unreleased] to the changelog file. See how we did it for 1.2.0-dev.
  3. I would have a commit in the PR adding a line to the changelog, under the Unreleased section, explaining what was fixed.