astarte-platform / astarte-device-sdk-esp32

Astarte device SDK for ESP32 devices, based on esp-idf
Apache License 2.0
13 stars 11 forks source link

No return value of the `mbedtls` library functions is evaluated #179

Closed sorru94 closed 1 year ago

sorru94 commented 1 year ago

The HWID module and the UUID module use the mbedtls library but do not check the return value of any of its functions.

https://github.com/astarte-platform/astarte-device-sdk-esp32/blob/c790919f5a8e2a968f73ef2c48bcbcf32cbfe38d/src/astarte_hwid.c#L78-L83

https://github.com/astarte-platform/astarte-device-sdk-esp32/blob/c790919f5a8e2a968f73ef2c48bcbcf32cbfe38d/src/astarte_hwid.c#L94

https://github.com/astarte-platform/astarte-device-sdk-esp32/blob/c790919f5a8e2a968f73ef2c48bcbcf32cbfe38d/src/uuid.c#L88-L94

sorru94 commented 1 year ago

The functions with ignored return values are: