search

astarte-platform / astarte-device-sdk-rust

Apache License 2.0
6 stars 12 forks source link

fix(interfaces): correct the iteration logic #334

Closed joshuachp closed 6 months ago

joshuachp commented 6 months ago

There was a bug in the iteration that would iterate only on the single added interface in the method Interfaces::iter_with_added. This will generate an incorrect introspection for MQTT connection.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.4%. Comparing base (326eb12) to head (2fc64e8). Report is 1 commits behind head on release-0.8.

Additional details and impacted files | [Files](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/334?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform) | Coverage Δ | | |---|---|---| | [src/interfaces.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/334?src=pr&el=tree&filepath=src%2Finterfaces.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2ludGVyZmFjZXMucnM=) | `76.9% <100.0%> (-1.0%)` | :arrow_down: | | [src/transport/grpc/mod.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/334?src=pr&el=tree&filepath=src%2Ftransport%2Fgrpc%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9ncnBjL21vZC5ycw==) | `66.6% <100.0%> (+2.8%)` | :arrow_up: | | [src/transport/mqtt/mod.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/334?src=pr&el=tree&filepath=src%2Ftransport%2Fmqtt%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9tcXR0L21vZC5ycw==) | `89.4% <100.0%> (+9.6%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/334/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform)