astarte-platform / astarte-device-sdk-rust

Apache License 2.0
6 stars 12 forks source link

Reflect the message hub proto api changes #362

Closed rgallor closed 1 week ago

rgallor commented 2 months ago

Since the Message Hub server can now send custom errors through the gRPC connection (and not only AstarteMessages), the sdk changes are meant to provide this error information to the client.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 41.12150% with 63 lines in your changes missing coverage. Please review.

Project coverage is 68.6%. Comparing base (004789a) to head (146cba9). Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/error.rs 0.0% 20 Missing :warning:
src/connection.rs 58.3% 15 Missing :warning:
src/transport/grpc/mod.rs 21.0% 15 Missing :warning:
src/client.rs 27.2% 8 Missing :warning:
src/transport/mqtt/mod.rs 78.5% 3 Missing :warning:
src/transport/grpc/convert.rs 83.3% 1 Missing :warning:
src/transport/mqtt/config/mod.rs 0.0% 1 Missing :warning:
Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform) | Coverage Δ | | |---|---|---| | [src/aggregate.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Faggregate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2FnZ3JlZ2F0ZS5ycw==) | `70.0% <ø> (ø)` | | | [src/interface/def.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Finterface%2Fdef.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2ludGVyZmFjZS9kZWYucnM=) | `71.9% <ø> (ø)` | | | [src/interface/mod.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Finterface%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2ludGVyZmFjZS9tb2QucnM=) | `78.6% <ø> (ø)` | | | [src/interfaces.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Finterfaces.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2ludGVyZmFjZXMucnM=) | `78.8% <ø> (ø)` | | | [src/transport/mqtt/error.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Ftransport%2Fmqtt%2Ferror.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9tcXR0L2Vycm9yLnJz) | `100.0% <ø> (ø)` | | | [src/transport/mqtt/topic.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Ftransport%2Fmqtt%2Ftopic.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9tcXR0L3RvcGljLnJz) | `55.5% <ø> (ø)` | | | [src/transport/grpc/convert.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Ftransport%2Fgrpc%2Fconvert.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9ncnBjL2NvbnZlcnQucnM=) | `95.0% <83.3%> (-0.6%)` | :arrow_down: | | [src/transport/mqtt/config/mod.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Ftransport%2Fmqtt%2Fconfig%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9tcXR0L2NvbmZpZy9tb2QucnM=) | `66.6% <0.0%> (ø)` | | | [src/transport/mqtt/mod.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Ftransport%2Fmqtt%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL3RyYW5zcG9ydC9tcXR0L21vZC5ycw==) | `62.9% <78.5%> (-0.2%)` | :arrow_down: | | [src/client.rs](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree&filepath=src%2Fclient.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform#diff-c3JjL2NsaWVudC5ycw==) | `62.5% <27.2%> (-2.3%)` | :arrow_down: | | ... and [3 more](https://app.codecov.io/gh/astarte-platform/astarte-device-sdk-rust/pull/362?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astarte-platform) | |
rgallor commented 2 weeks ago

In this PR I can't update the astarte-message-hub-proto version to v0.7.0 since it also contains modification to the Attach rpc, made in the `related PR #372 .