astarte-platform / astarte

Core Astarte Repository
https://docs.astarte-platform.org/
Apache License 2.0
239 stars 46 forks source link

Realm Management: do not crash on synchronous operations #853

Closed Annopaolo closed 11 months ago

Annopaolo commented 11 months ago

Successful synchronous operations (e.g. installation of an interface) may have led to a crash when the response was not encoded. Add back a removed clause to the encoding reply function to fix it.

codecov[bot] commented 11 months ago

Codecov Report

Merging #853 (fdb3dba) into release-1.1 (e33f1f1) will decrease coverage by 0.02%. Report is 3 commits behind head on release-1.1. The diff coverage is 0.00%.

:exclamation: Current head fdb3dba differs from pull request most recent head 49e15ca. Consider uploading reports for the commit 49e15ca to get more accurate results

@@               Coverage Diff               @@
##           release-1.1     #853      +/-   ##
===============================================
- Coverage        67.38%   67.37%   -0.02%     
===============================================
  Files              264      264              
  Lines             6430     6431       +1     
===============================================
  Hits              4333     4333              
- Misses            2097     2098       +1     
Files Coverage Δ
...gement/lib/astarte_realm_management/rpc/handler.ex 18.46% <0.00%> (-0.29%) :arrow_down: