astarte-platform / astarte

Core Astarte Repository
https://docs.astarte-platform.org/
Apache License 2.0
238 stars 46 forks source link

AppEngine: display device deletion status in details #882

Closed Annopaolo closed 8 months ago

Annopaolo commented 9 months ago

Deletion status is be displayed both for detailed device list and for device status. Device details now include the deletion_in_progress field. In case of database error, it defaults to false (as done for the connected field).

Note that this implies one more query for each device, as the deletion status is stored in the deletion_in_progress table.

Close #881.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f3b3ea6) 68.32% compared to head (94c1686) 68.36%. Report is 7 commits behind head on master.

Files Patch % Lines
...ne_api/lib/astarte_appengine_api/groups/queries.ex 76.92% 3 Missing :warning:
...ne_api/lib/astarte_appengine_api/device/queries.ex 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #882 +/- ## ========================================== + Coverage 68.32% 68.36% +0.04% ========================================== Files 270 270 Lines 6986 7011 +25 ========================================== + Hits 4773 4793 +20 - Misses 2213 2218 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.