Closed Annopaolo closed 7 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
0d96e22
) 68.35% compared to head (3cff047
) 68.33%.
Files | Patch % | Lines |
---|---|---|
...gine/lib/astarte_trigger_engine/events_consumer.ex | 0.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now that astarte_core defines introspection as a map interfacename => %IntrospectionEntry{major: , minor: _} rather than a plaintext string in incoming introspection triggers, this should be handled in DUP and TE (see https://github.com/astarte-platform/astarte_core/pull/77).
AMQP trigger events are defined in astarte_core, while HTTP trigger events will return introspection as a JSON map interface_name -> {major, minor} instead of the plain introspection string sent by the device.
It is possible to revert to the old behaviour by setting the
DATA_UPDATER_PLANT_GENERATE_LEGACY_INCOMING_INTROSPECTION_EVENTS
flag totrue
(default:false
). This change is thus BREAKING.