search

astarte-platform / astarte

Core Astarte Repository
https://docs.astarte-platform.org/
Apache License 2.0
238 stars 46 forks source link

BREAKING: Incoming introspection event introspection map #883

Closed Annopaolo closed 7 months ago

Annopaolo commented 9 months ago

Now that astarte_core defines introspection as a map interfacename => %IntrospectionEntry{major: , minor: _} rather than a plaintext string in incoming introspection triggers, this should be handled in DUP and TE (see https://github.com/astarte-platform/astarte_core/pull/77).

AMQP trigger events are defined in astarte_core, while HTTP trigger events will return introspection as a JSON map interface_name -> {major, minor} instead of the plain introspection string sent by the device.

It is possible to revert to the old behaviour by setting the DATA_UPDATER_PLANT_GENERATE_LEGACY_INCOMING_INTROSPECTION_EVENTS flag to true (default: false). This change is thus BREAKING.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0d96e22) 68.35% compared to head (3cff047) 68.33%.

Files Patch % Lines
...gine/lib/astarte_trigger_engine/events_consumer.ex 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #883 +/- ## ========================================== - Coverage 68.35% 68.33% -0.02% ========================================== Files 270 270 Lines 7028 7046 +18 ========================================== + Hits 4804 4815 +11 - Misses 2224 2231 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Annopaolo commented 8 months ago

Based on https://github.com/astarte-platform/astarte_core/pull/77