astarte-platform / astarte

Core Astarte Repository
https://docs.astarte-platform.org/
Apache License 2.0
240 stars 50 forks source link

DUP: move AMQP handling logic to Mississippi #995

Closed Annopaolo closed 1 month ago

Annopaolo commented 2 months ago

What this PR does / why we need it:

Use the Mississippi framework to manage messages coming from VerneMQ. This allows to retain the same ordering and delivery guarantees, while moving to the external component all the intricacies of handling messages in a distributed setting. This will also increase the ease of contributing to the core message handling logic, as now code only works on what to do once a message is arrived, instead of also including how to receive a message.

Note that e2e tests will fail until https://github.com/astarte-platform/astarte_vmq_plugin/pull/94 is merged.

Which issue(s) this PR fixes:

(none)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g. usage docs, diagrams, etc.:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.35%. Comparing base (d9bc432) to head (7949de7). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #995 +/- ## ========================================== + Coverage 68.46% 69.35% +0.88% ========================================== Files 282 275 -7 Lines 7488 7149 -339 ========================================== - Hits 5127 4958 -169 + Misses 2361 2191 -170 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.