search

astarte-platform / astarte_vmq_plugin

Astarte VerneMQ plugin publishes incoming messages on an AMQP exchange with some additional metadata, so they can be processed by other components.
http://astarte-platform.org/
Apache License 2.0
16 stars 10 forks source link

Remove explicit persistency defaults, allow to configure them #26

Closed rbino closed 4 years ago

rbino commented 4 years ago

With https://github.com/astarte-platform/astarte/pull/386 AppEngine now makes sure the message gets delivered to the device before returning 200. persistent_client_expiration and max_offline_messages influence this behavior, since they limit the lifetime and quantity of messages that will be delivered to the device. Therefore, these values are made tunable via the docker env vars mechanism.

Signed-off-by: Riccardo Binetti riccardo.binetti@ispirata.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   74.57%   74.57%           
=======================================
  Files           8        8           
  Lines         177      177           
=======================================
  Hits          132      132           
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 598079d...9d232b1. Read the comment docs.