search

astarub / campus_app

Campus App of Ruhr-University Bochum
https://app.asta-bochum.de
GNU Affero General Public License v3.0
13 stars 4 forks source link

Misleading GUI on Holidays #157

Open MixColumns opened 5 months ago

MixColumns commented 5 months ago

Currently the opening times are shown as wall as that the mensa is open when those times are given without any regard to the weekday (see https://github.com/astarub/campus_app/issues/156). This creates the impression the mensa would be open on 01.04. even though its a holiday. It seems like no plan is available but the mensa is open.

This should be fixed by e.g. adding a term to the opening times like "regular opening times:". The infotext about no plan available could be extended to "The mensa might be closed as we were not able to fetch any data". Ofc there are other options regarding the GUI and styling. It should be somehow clear that the mensa is closed on holidays.

photo_5208673936018102235_y

domai-tb commented 5 months ago

Thank you for reporting this issue. We will address this issue (and #156 as well) in the next overall improvement of the Mensa page. Currently, there is no PR or Issue for improving the Mensa page, but you can follow the progress on the mensa-improvement branch.

BizarrePenguin commented 4 months ago

I want to add, that it would be really helpful if the mensas would be willing to set up a system where they can announce non-regular opening and closing times which the campus app could then react to. E.g. today the Q-West was closed early and many people tried to enter because they thought it was still opened. The campus app still shows it as opened as it would be on a regular friday. Maybe someone with contacts to the mensa teams can try to establish something?

Maybe as a first solution just a feature that the opening times are based on a calendar on some AStA web server that the campus app team can manually manage?

domai-tb commented 4 months ago

Hey, the problem with irregular and especially spontaneously switching opening hours is, that the AKAFÖ doesn't have a central instance to accomplish the opening hours. And communicating with AKAFÖ is definitely not easy going ...

In #160, the UI shows the opening hours explicit as "regular" and an hint that the data could be wrong. Furthermore, the app could load a list of public holidays and shows them as closed on these days.