astashov / crossdart

Cross-reference of Dart packages
http://crossdart.info
BSD 2-Clause "Simplified" License
13 stars 3 forks source link

Problems with overridden dependencies from git #12

Closed RobertBlackhart closed 8 years ago

RobertBlackhart commented 8 years ago

I just found your project and I was excited to try it out. I am having an issue when crossdart is running against my project (https://github.com/ChildrenOfUr/coUserver):

https://www.crossdart.info/metadata/ChildrenOfUr/coUserver/8dd37ada33f0901edf66467ef4531c4209d13c92/log.txt

12:19:55.122 [INFO] dartdoc: Stderr: Warning: You are using these overridden dependencies:
! redstone 0.6.6 from git https://github.com/redstone-dart/redstone.git at be2d24
! redstone_mapper_pg 0.2.0-beta.2 from git https://github.com/RobertMcDermot/redstone_mapper_pg.git at 604777

12:19:55.338 [INFO] dartdoc: Running 'pub global run crossdart --input=/root/csoutput/ChildrenOfUr/coUserver/8dd37ada33f0901edf66467ef4531c4209d13c92 --output=/root/csoutput/ChildrenOfUr/coUserver/8dd37ada33f0901edf66467ef4531c4209d13c92 --hosted-url=https://www.crossdart.info --url-path-prefix=p --output-format=github --dart-sdk=/usr/lib/dart'
12:19:56.201 [INFO] dartdoc: Stdout: 12:19:55.844 [INFO] environment: Building environment

12:19:56.201 [INFO] dartdoc: Stderr: Unhandled exception:
FormatException: Could not parse "be2d24ab2c5c8087f020be117f84d966081aed6a".
#0      Version.Version.parse (package:pub_semver/src/version.dart:116)
#1      buildEnvironment.<buildEnvironment_async_body> (package:crossdart/src/environment.dart:51)
#2      _RootZone.runUnary (dart:async/zone.dart:1204)
#3      _FutureListener.handleValue (dart:async/future_impl.dart:131)
#4      _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:637)
#5      _Future._propagateToListeners (dart:async/future_impl.dart:667)
#6      _Future._complete (dart:async/future_impl.dart:467)
#7      _SyncCompleter.complete (dart:async/future_impl.dart:52)
#8      buildCustomPackageFromFileSystem.<buildCustomPackageFromFileSystem_async_body> (package:crossdart/src/package.dart:203)
#9      Future.Future.microtask.<anonymous closure> (dart:async/future.dart:144)
#10     _microtaskLoop (dart:async/schedule_microtask.dart:41)
#11     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#12     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#13     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_pat
```ch.dart:149)

It seems to be trying to parse the git commit hashes from the overridden dependencies as regular 1.2.3 version numbers.
RobertBlackhart commented 8 years ago

Sorry, I didn't mean for this issue to reference the other first 12 issues. I'm not sure how to break those links after the fact. I had originally used the quote tool for my stack trace above, but then the numbered stack frames linked to every issue you have. I changed it to a code block to try and fix that, but it only changed here and not in the related issues.

astashov commented 8 years ago

Yeah, it seems like pub_semver package doesn't work with git hashes, because they are not very semver-compatible :) I'll try to fix it today. Thanks for checking it out!

astashov commented 8 years ago

Please try again, should be fixed.

RobertBlackhart commented 8 years ago

Thanks for the quick fix. Things seem to be working now.