Hi there :)
Thanks heaps for this app!
I've started to use it and I am keen to help improve it even further.
My javascript is rusty so I would appreciate your review.
I noticed that when making personal records, the number of reps displayed did not match the true highest reps performed with that weight (e.g. with an AMRAP set).
Example:
I was expecting the PR to be "10x45 lb" but instead:
I've tracked down the logic to History.getMaxSet and added logic to compare 2 sets using the completedReps when the weights are the same. I've also added a small unit test covering this use case.
Results:
Hi there :) Thanks heaps for this app! I've started to use it and I am keen to help improve it even further. My javascript is rusty so I would appreciate your review.
I noticed that when making personal records, the number of reps displayed did not match the true highest reps performed with that weight (e.g. with an AMRAP set).
Example:
I was expecting the PR to be "10x45 lb" but instead:
I've tracked down the logic to
History.getMaxSetand added logic to compare 2 sets using the completedReps when the weights are the same. I've also added a small unit test covering this use case. Results: