search

astashov / liftosaur

Weightlifting tracker app for coders
https://www.liftosaur.com
GNU Affero General Public License v3.0
243 stars 32 forks source link

Bodyfat Measurement #46

Closed ghost closed 1 year ago

ghost commented 1 year ago

I am switching over from the Hevy App and the only thing I am missing is the ability to track my bodyfat percentage alongside my bodywieght, so I decided to add it myself.

astashov commented 1 year ago

Woah, this is awesome!!! I'm on vacation right now, but will be back next Wednesday, and will check it out! Thanks for contributing!

astashov commented 1 year ago

Could you also please add bodyfat percentage support to ModalGraphs.tsx, so it'd show up there:

image

That's when you press on Graphs in the footer, and then Filter in the navbar.

ghost commented 1 year ago

Hey Anton, thanks for the review. I'm currently on vacation as well, but I'll look into it when I get back on Wednesday.

ghost commented 1 year ago

I hope everything looks better now. I changed the logic of the info messages a little bit, because it was not possible to look at body measurement graphs if you haven't completed a workout yet. So I show only the available graphs in the graph selection modal and add an info message if none are available.

astashov commented 1 year ago

Hey @codymurdoc! I frankly messed up a bit with the history, and committed/pushed the changes separately, and not merging your PR, sorry...

But your changes are in master now, thank you soooo much for contribution! That's a really big feature, and it's really cool you just went ahead and added it!

As a reward for your contribution, do you want a free life-time access to the app? If so, let me know your user id (it's on the Settings -> Account, it says like id: asfdasdfe), and I'll add free access for that id.

Thanks again!

ghost commented 1 year ago

Hey @astashov, I’m always happy to contribute :) If I find the time I plan on going through your To-Do list and see what I can do.

I really appreciate your offer. I would love to get premium access. My user ID is mihgquscfh. Thanks again!

astashov commented 1 year ago

Okay, added the access. You should go to the subscription screen, and press the "Get it!" button, and it should activate.

If I find the time I plan on going through your To-Do list and see what I can do.

That'd be highly appreciated! :) But I'm not doing a very good job keeping TODO in sync and actual, so if you have time, better contact me either via info@liftosaur.com, or find me on our Discord channel, and we can discuss what to do there! Thanks!