search

astaxie / bat

Go implement CLI, cURL-like tool for humans
Apache License 2.0
2.55k stars 220 forks source link

Vendoring dependencies #16

Closed glkz closed 9 years ago

glkz commented 9 years ago

@astaxie what is the proposed way for adding external packages to bat. What do you think about using something like godep?

astaxie commented 9 years ago

yea, godep is awesome

astaxie commented 9 years ago

But why do bat need to import third package? if want to import third package, I think interface is the best solution.

glkz commented 9 years ago

IMHO, using main package for third party libraries pollutes and complicates main namespace. I think they should be in their own sub-package like httplib.

At this point a tool like godep standardizes that process and makes vendoring easier by rewriting the dependencies' namespaces.

BTW, I asked this mainly because I wanted to add a dependency (ansicolor) to make response formatting code and user interface uniform (i.e windows independent).

astaxie commented 9 years ago

That make sense. it looks ansicolor is cool.