astaxie / bat

Go implement CLI, cURL-like tool for humans
Apache License 2.0
2.55k stars 220 forks source link

Add ansi-color support for windows #26

Closed glkz closed 9 years ago

glkz commented 9 years ago

Integrated shiena/ansicolor.

We need to change color scheme a little bit. I am not a windows guy but as far as I can see windows shell does not support ansi codes like 90, 91. But codes like 30, 31, ... seem ok.

Taking #25 also into consideration, it may be good to rethink the built-in color scheme for larger platform support.

glkz commented 9 years ago

ping @astaxie. What do you think about merging this?

It doesn't break anything in windows right now. Just the default color-scheme should be re-arranged. I think it is a different story.

postromantic commented 8 years ago

What was the reason not to merge this PR? I'm still using this fork https://github.com/glkz/bat/commits/feature-ansicolor_win on all my Windows machines (using bash for windows and cygwin) and it works well.