asteca / ASteCA

Code for the ASteCA package.
http://asteca.github.io/
MIT License
18 stars 6 forks source link

Use kde values to generate the RDP #333

Closed Gabriel-p closed 5 years ago

Gabriel-p commented 7 years ago

The current RDP is obtained summing the number of stars in each 2D bin belonging to the same "square ring", and dividing by the area of the square ring.

An alternative approach would be to use instead the median of the KDE values evaluated at the center of each bin in the square ring. This would require to fit a KDE to the entire frame, and position the grid where it is evaluated so that it goes through the center of the bins defined by the 2D x,y histo.

The advantage is that the KDE is less susceptible to change if the center coordinates are changed. The current RDP depends strongly on the center coordinates used to define the square rings.

Related: #76, #155, #245, #287

Gabriel-p commented 5 years ago

I tested this method here https://github.com/asteca/ASteCA/commit/a80542602abc11f4e7a0d0774cf2f30630da7da7, but it turns out that the results are very dependent on the selected bandwidth for the KDE.

I decided to use the standard circular rings method, with the help of a simple Monte Carlo algorithm to estimate the areas.