search

astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.19k stars 176 forks source link

Add support for NueDeck #188

Closed twitwi closed 5 years ago

twitwi commented 5 years ago

This plugin is for NueDeck (a reboot of deck.js (and many extensions), using Vue.js, https://github.com/twitwi/nuedeck )

I don't know what is the policy for including new plugins into the main repo:

Thanks for working on decktape.

astefanutti commented 5 years ago

Thanks a lot for the PR.

I don't know what is the policy for including new plugins into the main repo:

  • NueDeck is currently very new, is this blocking?

Not at all.

  • should I update the decktape readme for the PR?

Yes, I think you can update the list of supported plugins and the CLI help output.

  • also, is there a way for a plugin to change the default "pause"?

Currently no. I was thinking we could add an optional API, as it could help speeding up the export for some plugins a lot. Could you create an issue to track that enhancement?

twitwi commented 5 years ago

Thanks, I opened https://github.com/astefanutti/decktape/issues/189

twitwi commented 5 years ago

Readme updated! (with some pain)

astefanutti commented 5 years ago

Thanks, sorry for the poor man grid layout :)

Would you mind updating the CLI help by adding nuedeck to the possible values for the command?

twitwi commented 5 years ago

no problem, done

astefanutti commented 5 years ago

Thanks!