search

astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.17k stars 175 forks source link

Feature/optional timeout #247

Closed kurtfm closed 2 years ago

kurtfm commented 2 years ago

Moved the timeout value of 20000 into an option so it can be overridden. I just tested this locally and through docker (which is why I needed to update the chromium version as well). I am not all that familiar with the project so forgive me if this fix is not the right way to do this.

kurtfm commented 2 years ago

My bad! I will create a new PR. Actually realized there are two page load timeouts set ... wondering if it's ok to use the same timeout for both.

astefanutti commented 2 years ago

Let me close this as it's superseded by #248.