fix(deps): update dependencies

astefanutti / decktape

PDF exporter for HTML presentations

MIT License

2.17k stars 175 forks source link

fix(deps): update dependencies #250

Closed nicojs closed 1 year ago

nicojs commented 1 year ago

Fixes #249

I've tested it with a private presentation and it looked good. Please test it on any test pdfs you might have.

Note: I've not updated chalk to the @latest version (v5) as chalk migrated to ESM (ECMAScript modules). If you want, I can make a separate PR to migrate decktape to use ESM internally.

astefanutti commented 1 year ago

Thanks a lot!

I've done some testing and spotted two regressions:

One with Reveal presentations that causes the slides not to resize as usual;
The second with the overall size of the PDFs.

These are introduced with Puppeteer 1.19. In the meantime I manage to troubleshoot / fix those regressions, I'd suggest we upgrade to Puppeteer 18.2.1, that seems to fix the audit warnings. Would that work for you?

astefanutti commented 1 year ago

Let's merge this. I'll downgrade Puppeteer to 18.2.1 until we fix the regressions.

Thanks.

nicojs commented 1 year ago

Thanks, sorry it took a while for me to react here. You want me to migrate decktape itself to native esm?

astefanutti commented 1 year ago

Thanks, sorry it took a while for me to react here. You want me to migrate decktape itself to native esm?

No worries. That'd be awesome. I'm not sure how large an effort that is, but more than happy to accept a PR 👍🏼.