astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.17k stars 175 forks source link

test(harness): Add e2e testing harness using playwright #254

Closed nicojs closed 1 year ago

nicojs commented 1 year ago

Add a e2e testing harness using playwright. Also add 1 demo scenario using the revealjs demo presentation

To add more e2e tests, add more scenarios to the test/input directory. New scenarios found there are automatically picked up.

Closes #253

nicojs commented 1 year ago

I see that the demo has a lot of external images. This can be a problem because the tests could fail because of a change on their end. Maybe it's better to pull them into the input/revealjs-demo directory? What do you think @astefanutti ?

nicojs commented 1 year ago

It turned out to be not a lot of files, so I went ahead and did it.

nicojs commented 1 year ago

That's actually a great idea, I wasn't thinking about that. It would mean a manual "update-snapshot" process, which I can automate for you in the update-snapshots workflow.

astefanutti commented 1 year ago

That's actually a great idea, I wasn't thinking about that. It would mean a manual "update-snapshot" process, which I can automate for you in the update-snapshots workflow.

That manual "update-snapshot" would be perfectly ok. Would you rather prefer to have that PR merged as is, or keep it open until we move to using PDFs as the source of truth? I'm fine either ways 👍🏼.

astefanutti commented 1 year ago

Let's merge this. We can look into using PDFs as the source of truth later. Thanks again!