astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.17k stars 175 forks source link

feat(revealjs): disable menu open button #260

Closed sagikazarmark closed 1 year ago

sagikazarmark commented 1 year ago

This is a workaround for denehyg/reveal.js-menu#99

When the RevealMenu plugin is enabled, there is a menu button on the printed slides.

This change disables that menu during printing.

This isn't necessarily the best possible solution, but since there is no "official" API for updating plugin configuration and the RevealMenu plugin does not expose any destroy or hide button API, this is the best alternative at the moment.

astefanutti commented 1 year ago

Thanks!

sagikazarmark commented 1 year ago

Thanks for quickly merging it!

sagikazarmark commented 1 year ago

@astefanutti would you consider releasing a new version with this fix? Thanks!

astefanutti commented 1 year ago

@sagikazarmark thanks for the reminder. I've just released version 3.6.0 that contains this fix. Thanks again!

sagikazarmark commented 1 year ago

Awesome, thanks!