astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.16k stars 175 forks source link

Docker image error #284

Closed AntonShevchuk closed 1 year ago

AntonShevchuk commented 1 year ago

Hi

I try to use the newest version of the docker image and receive a very strange error:

Error: Unable to write GSUB: script latn has no default language system.
    at fail (/decktape/node_modules/opentype.js/dist/opentype.js:919:12)
    at Object.argument (/decktape/node_modules/opentype.js/dist/opentype.js:926:10)
    at /decktape/node_modules/opentype.js/dist/opentype.js:2032:20
    at recordList (/decktape/node_modules/opentype.js/dist/opentype.js:1990:33)
    at new ScriptList (/decktape/node_modules/opentype.js/dist/opentype.js:2029:10)
    at Object.makeGsubTable [as make] (/decktape/node_modules/opentype.js/dist/opentype.js:6874:50)
    at Object.fontToSfntTable [as fontToTable] (/decktape/node_modules/opentype.js/dist/opentype.js:7220:27)
    at Font.toTables (/decktape/node_modules/opentype.js/dist/opentype.js:13545:18)
    at Font.toArrayBuffer (/decktape/node_modules/opentype.js/dist/opentype.js:13559:27)
    at file:///decktape/decktape.js:400:73

With version 3.7 all was good, I just convert index.html with reveal.js:

node /decktape/decktape.js --chrome-path chromium-browser ./index.html ./index.pdf
astefanutti commented 1 year ago

That looks like a regression introduced by the migration to opentype.js (#280).

I haven't faced the issue on the number of presentations I've tested. Could you share your presentation, so I can try to reproduce? Or give some details that could help identify the root cause?

AntonShevchuk commented 1 year ago

I can share it with you personal, it is not a public project yet. You can mail me, I will send you the files.

eitansuez commented 1 year ago

fwiw i also just ran into this very same error (also a private repository, sorry).

christopher-besch commented 1 year ago

It also fails with one of my public presentations. Try it with:

docker run --rm -t --net=host -v `pwd`:/slides astefanutti/decktape https://present.chris-besch.com/2022_06_24_reveal_example/ slides.pdf
JanoschDeurer commented 1 year ago

Same here, for all our slides. For me going back to astefanutti/decktape:3.7 worked.

bast commented 1 year ago

A public example where 3.8 fails and 3.7 works: https://cicero.xyz/v3/remark/0.14.0/github.com/constructicon/presentations/main/open-code-open-data.md/

astefanutti commented 1 year ago

It should be fixed in 3.9.0 release.

Thanks a lot for the report!

bast commented 1 year ago

Thanks a lot for the fix and this great tool!