astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.16k stars 175 forks source link

Fix: asynchronously wait for the browser to close before exiting the process #321

Closed jsarem closed 5 months ago

jsarem commented 5 months ago

Decktape doesn't wait for the browser to close before exiting the node process. This causes the browser to crash and not to remove temporary files, leaving them in /tmp directory.

See: https://pptr.dev/api/puppeteer.browser.close

Related issue: https://github.com/astefanutti/decktape/issues/295

astefanutti commented 5 months ago

Thanks a lot for your contribution!