search

astefanutti / decktape

PDF exporter for HTML presentations
MIT License
2.16k stars 175 forks source link

Include progess bar when exporting revealjs slides #330

Closed FriederRodewald closed 2 months ago

FriederRodewald commented 2 months ago

Thanks so much for this great tool! I was wondering whether there is a way to export the revealjs progress bar to the pdf slides? Currently, the progress bar is not printed to the slides, but it would be nice if it was displayed there was well. If this is not doable, you can just close the issue and others wondering about the same feature might stumble upon this post :)

astefanutti commented 2 months ago

Thanks for the feedback :)

The progress bar is currently disabled explicitly in the reveal.js plugin here: https://github.com/astefanutti/decktape/blob/6735cec96dad6b32ee43d04f858b9794081cb866/plugins/reveal.js#L36

There could be an option to turn it on. If that'd work for you, I'd be more than happy to accept a PR :)

FriederRodewald commented 2 months ago

Thanks for the tip; I created a pull request implementing the functionality. For me it works using decktape reveal http://localhost:9999/\?fragments\=true\&progress\=true test.pdf.

astefanutti commented 2 months ago

Let's close this as it's been fixed with #331. Note it's now an option of the reveal plugin, not a URL parameter.