search

astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.14k stars 142 forks source link

Add undefined check for NodeJD TLS certifactes before using them #119

Closed johnpoth closed 3 years ago

johnpoth commented 3 years ago

Was getting 

TypeError: Cannot read property 'concat' of undefined
    at Context.getMasterApi (/home/jpoth/dev/git/kubik/lib/config/context.js:96:37)
    at new Kubebox (/home/jpoth/dev/git/kubik/lib/kubebox.js:41:57)
    at Object.<anonymous> (/home/jpoth/dev/git/kubik/index.js:68:1)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Function.Module.runMain (module.js:694:10)
    at startup (bootstrap_node.js:204:16)

Thanks !

astefanutti commented 3 years ago

What version of NodeJS do you use? The minimal required version is now 12.3.0: d86053f575c29f865a7984003cca454c147a5916.

It simplifies TLS CA certificates management: a6d9557384269e815e4bb126f6163e23d3cf2fef, and most users rely on the standalone executables, which is align with the minimal NodeJS version.

johnpoth commented 3 years ago

Ah yes it does simplify things a bit ! Closing as newer NodeJS solves this issue (empty array instead of undefined is returned +1), closing