astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.16k stars 140 forks source link

Suggestion: Remove guide to change role of default service account on RBAC section #34

Closed JCMais closed 5 years ago

JCMais commented 5 years ago

Making the default service account have cluster-admin role is a tremendous security vulnerability, it's probably a better idea to change the service account used on the deployment, and put the manifest to create the service account / cluster role / cluster role binding on the same file.

astefanutti commented 5 years ago

Thanks for the suggestion. Makes much sense. We'll apply it ASAP.

JCMais commented 5 years ago

Thanks @astefanutti, really appreciate the tool you built!

astefanutti commented 5 years ago

Implemented in b252eb76c9dbe4f685d87f0531788709637f6f7c. Feel free to review it.