search

astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.14k stars 142 forks source link

Add basic support for Exec auth #54

Closed johnpoth closed 4 years ago

johnpoth commented 4 years ago

Adds basic support for Exec Auth (browser is not supported). Tested on EKS. #32 #53 Thanks!

johnpoth commented 4 years ago

Thanks for reviewing! I've addressed the comments and I added another commit to support Digital Ocean. Let me know if you prefer them squashed?

Should we add something to the readme now or wait when we're about to release? I was thinking of a support matrix browser/no browser auth support. Thanks!

astefanutti commented 4 years ago

Thanks for reviewing! I've addressed the comments and I added another commit to support Digital Ocean. Let me know if you prefer them squashed?

Better keeping the two commits.

Should we add something to the readme now or wait when we're about to release? I was thinking of a support matrix browser/no browser auth support. Thanks!

I'm fine with updating the README now, even if it should theoretically be done post-release. Anyway, I was thinking cutting a release ASAP, with all the awesome stuff you've added. I like the idea of the support matrix. I would suggest to put it into a dedicated section in the README.

johnpoth commented 4 years ago

Thanks for reviewing! I've addressed the comments and I added another commit to support Digital Ocean. Let me know if you prefer them squashed?

Better keeping the two commits.

Should we add something to the readme now or wait when we're about to release? I was thinking of a support matrix browser/no browser auth support. Thanks!

I'm fine with updating the README now, even if it should theoretically be done post-release. Anyway, I was thinking cutting a release ASAP, with all the awesome stuff you've added. I like the idea of the support matrix. I would suggest to put it into a dedicated section in the README.

Added a note in the README

johnpoth commented 4 years ago

Updated PR, thanks!

astefanutti commented 4 years ago

Thanks! I'll try to cut a release ASAP.