astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.16k stars 140 forks source link

Bug with exec auth and env #56

Closed codertao closed 5 years ago

codertao commented 5 years ago

PR #54 added support for exec auth, but it doesn't seem to support environment correctly.

KubeConfig from aws is of form: user: exec: env:

But child_process.exec is expecting env to be of form {AWS_PROFILE: saml}.

Can probably submit a PR this week if I get the time to sit down.

astefanutti commented 5 years ago

Thanks a lot for the report. That’d be awesome if you could create a PR. We’ll cut a new release then.

astefanutti commented 5 years ago

Should be fixed with 9f70c9fd8e2b6237d8a81118544779a5ce4f89e3. Thanks!